Account layout template adjustments #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrucadu
approved these changes
Oct 26, 2021
danacotoran
changed the title
danacotoran
force-pushed
the
account-template-adjustments
branch
from
a03aad4 to
30ea689
Compare
danacotoran
force-pushed
the
account-template-adjustments
branch
2 times, most recently
from
c4b902b to
d8c2b0a
Compare
Implement some adjustments to the layout template for accounts to ensure a smooth transition to DI auth. Remove the Account product name from the header, and ensure the GOVUK link leads back to the GOVUK homepage so users don't get stuck in the account zone. Remove footer navigation links in favour or the more stripped down version of the footer. We want the footer to match what DI have implemented (it could look weird if the footer dramatically changes when someone navigates from one account page to another)
danacotoran
force-pushed
the
account-template-adjustments
branch
from
d8c2b0a to
0233c2b
Compare
danacotoran
force-pushed
the
account-template-adjustments
branch
from
1e5d4e5 to
ff12b9b
Compare
danacotoran
force-pushed
the
account-template-adjustments
branch
from
ff12b9b to
aab9f52
Compare
danacotoran
force-pushed
the
account-template-adjustments
branch
from
aab9f52 to
0233c2b
Compare
danacotoran
changed the title
barrucadu
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement some adjustments to the layout template for accounts to ensure
a smooth transition to DI auth.
Remove the Account product name from the header, and ensure the GOVUK
link leads back to the GOVUK homepage so users don't get stuck in the
account zone.
Remove footer navigation links in favour or the more stripped down
version of the footer. We want the footer to match what DI have
implemented (it could look weird if the footer dramatically changes when
someone navigates from one account page to another)
https://trello.com/c/vIjbnGSj/1087-account-pages-tidy-up-for-launch
Related PR which implements similar minor changes to the account layout in the components gem: alphagov/govuk_publishing_components#2380